Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add generator #319

Merged
merged 14 commits into from
Aug 4, 2023
Merged

feat: add generator #319

merged 14 commits into from
Aug 4, 2023

Conversation

Chronostasys
Copy link
Member

@Chronostasys Chronostasys commented Jul 13, 2023 •
edited
Loading

related to #286

close #320

@Chronostasys Chronostasys requested review from RINNE-TAN and CjiW July 13, 2023 13:11
@Chronostasys Chronostasys force-pushed the Chronostasys/issue286 branch 9 times, most recently from d316485 to 80a1b38 Compare July 14, 2023 03:56
@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #319 (a332a47) into master (1739aba) will decrease coverage by 0.08%.
Report is 2 commits behind head on master.
The diff coverage is 85.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   85.88%   85.81%   -0.08%     
==========================================
  Files         101      100       -1     
  Lines       19613    20693    +1080     
==========================================
+ Hits        16845    17758     +913     
- Misses       2768     2935     +167
Files Changed Coverage Δ
immix/src/llvm_stackmap/mod.rs 3.84% <0.00%> (ø)
src/ast/builder/mod.rs 33.33% <ø> (ø)
src/ast/diag.rs 61.83% <ø> (ø)
src/ast/node/mod.rs 82.48% <ø> (ø)
src/ast/tokens.rs 70.83% <ø> (+4.16%) ⬆️
src/jar.rs 100.00% <ø> (ø)
src/ast/plmod.rs 77.85% <38.70%> (-3.34%) ⬇️
src/ast/ctx/builtins.rs 59.95% <48.13%> (-11.10%) ⬇️
src/ast/node/control.rs 92.62% <50.00%> (ø)
src/ast/range.rs 78.57% <50.00%> (-3.01%) ⬇️
... and 28 more

... and 13 files with indirect coverage changes

@Chronostasys Chronostasys force-pushed the Chronostasys/issue286 branch 5 times, most recently from bf83b39 to fb4ac94 Compare July 14, 2023 08:56
@Chronostasys Chronostasys marked this pull request as ready for review July 17, 2023 03:55
@Chronostasys Chronostasys force-pushed the Chronostasys/issue286 branch 2 times, most recently from 6f8b82e to e3e059e Compare July 19, 2023 09:31
@Chronostasys Chronostasys force-pushed the Chronostasys/issue286 branch 2 times, most recently from 527bfba to f301c4b Compare August 4, 2023 09:01
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Benchmark for 4b873fa

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1544.2±68.91µs 1757.7±471.64µs +13.83%
plimmixgc/multi-thread gc stress benchmark small objects 1184.7±45.50ms 1205.7±55.63ms +1.77%
plimmixgc/singlethread gc stress benchmark small objects 1078.6±23.83ms 1058.1±22.41ms -1.90%
singlethread gc benchmark--65535 small objects 1372.8±9.47µs 1349.2±39.87µs -1.72%
singlethread gc mark benchmark--65535 small objects 758.2±7.12µs 743.0±8.37µs -2.00%
singlethread gc sweep benchmark--65535 small objects 607.7±4.92µs 603.0±3.95µs -0.77%

@Chronostasys Chronostasys force-pushed the Chronostasys/issue286 branch from f301c4b to f1239e2 Compare August 4, 2023 09:26
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Benchmark for ac2b814

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1196.6±283.54µs 1122.6±32.38µs -6.18%
plimmixgc/multi-thread gc stress benchmark small objects 966.0±24.95ms 921.5±66.29ms -4.61%
plimmixgc/singlethread gc stress benchmark small objects 903.9±19.80ms 831.5±16.10ms -8.01%
singlethread gc benchmark--65535 small objects 1052.4±4.38µs 1051.2±2.10µs -0.11%
singlethread gc mark benchmark--65535 small objects 576.3±3.17µs 576.7±3.11µs +0.07%
singlethread gc sweep benchmark--65535 small objects 475.5±0.69µs 472.7±1.11µs -0.59%

@Chronostasys Chronostasys force-pushed the Chronostasys/issue286 branch from f1239e2 to a332a47 Compare August 4, 2023 09:44
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Benchmark for 468dc15

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1243.0±76.70µs 1302.6±201.51µs +4.79%
plimmixgc/multi-thread gc stress benchmark small objects 1152.7±29.16ms 1130.8±25.39ms -1.90%
plimmixgc/singlethread gc stress benchmark small objects 1048.1±18.28ms 1032.3±13.88ms -1.51%
singlethread gc benchmark--65535 small objects 1129.2±2.60µs 1101.4±2.47µs -2.46%
singlethread gc mark benchmark--65535 small objects 637.4±2.44µs 598.2±3.90µs -6.15%
singlethread gc sweep benchmark--65535 small objects 505.3±0.86µs 503.8±0.78µs -0.30%

@Chronostasys Chronostasys merged commit 3ce3747 into master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjiW CjiW CjiW approved these changes

@RINNE-TAN RINNE-TAN Awaiting requested review from RINNE-TAN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generator支持
2 participants
@Chronostasys @CjiW